Re: [PATCH 3/3] w1: add slave driver for DS1996 and DS1963L

[Evgeniy Polyakov]

Hi

On Fri, Feb 17, 2012 at 01:07:02PM +0100, Michael Thalmeier (michael.thalmeier@xxxxxxx) wrote:
> This driver adds support for some Dallas non-volatile memory 1-wire slave
> devices.
> 
> At the moment the following devices are supported:
> 
>  * family 0x0c: DS1996 64Kb Memory iButton
>  * family 0x1A: DS1963L 4kbit Monetary
> 
> Access to memory is done via pages exportedi in sysfs.
> 
> Signed-off-by: Michael Thalmeier <michael.thalmeier@xxxxxxx>

Looks good to me, although I would replace config option 
with sysfs-enabled parameter, since distros do not compile different
kernels with various options enabled.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/