Re: pull request: linux-firmware: update cxgb* firmwares

[Ben Hutchings]

On Fri, 2012-02-17 at 11:30 -0800, Divy Le Ray wrote:
> On 2/16/2012 7:41 PM, Ben Hutchings wrote:
> > On Wed, 2012-02-15 at 23:18 -0800, Divy Le Ray wrote:
> > [...]
> >> The following changes since commit 38118a598df73d5a9fd72bf04910e8298db82a46:
> >>
> >>     linux-firmware: brcm: add firmware for bcm43236 usb device
> >> (2012-02-11 19:20:10 +0000)
> >>
> >> are available in the git repository at:
> >>     git://git.chelsio.net/pub/git/linux-firmware for-upstream
> >>
> >> Divy Le Ray (3):
> >>         linux-firmware: rename t4fw.bin
> >>         linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
> >>         linux-firmware: update cxgb3 driver firmware to revision 7.12.0
> >>
> >>    WHENCE                  |    4 +++-
> >>    cxgb3/t3fw-7.12.0.bin   |  Bin 0 ->  31812 bytes
> >>    cxgb4/t4fw-1.3.10.0.bin |  Bin 0 ->  241664 bytes
> >>    cxgb4/t4fw-1.4.16.0.bin |  Bin 0 ->  298496 bytes
> >>    cxgb4/t4fw.bin          |  Bin 241664 ->  17 bytes
> >>    5 files changed, 3 insertions(+), 1 deletions(-)
> >>    create mode 100755 cxgb3/t3fw-7.12.0.bin
> >>    create mode 100644 cxgb4/t4fw-1.3.10.0.bin
> >>    create mode 100644 cxgb4/t4fw-1.4.16.0.bin
> >>    mode change 100644 =>  120000 cxgb4/t4fw.bin
> > Are there any versions of the cxgb4 driver that will specifically
> > request cxgb4/t4fw-1.3.10.0.bin?  If not, what's the point of keeping it
> > around after changing the cxgb4/t4fw.bin symlink?
> 
> Hi Ben,
> 
> I originally removed cxgb4/t4fw-1.3.10.0.bin when I posted the request 
> against David's tree.
> Subsequent review from Neil requested to keep it around at least for a 
> while (https://lkml.org/lkml/2012/2/11/61).
> Either way is fine to me.

No, Neil said you need to maintain cxgb4/t4fw.bin, but it's perfectly
fine for that to be a symlink.

Ben.

-- 
Ben Hutchings
Every program is either trivial or else contains at least one bug

Attachment: signature.asc
Description: This is a digitally signed message part