Re: [PATCH V1] mfd: tps65910: Initialize irq platform data properly

From: Laxman Dewangan
Date: Sun Feb 19 2012 - 02:37:09 EST


Hi Samuel,
Can you please review this patch? Without this change, the device is corrupting other irq registration because it tries to register wrong irqs.

Thanks,
Laxman

On Thursday 02 February 2012 07:26 PM, Laxman Dewangan wrote:
On Wednesday 18 January 2012 08:19 PM, Laxman Dewangan wrote:
irq_base of the tps65910 irq platform data should be
initialized with the board provided irq_base data.

Signed-off-by: Laxman Dewangan<ldewangan@xxxxxxxxxx>
---
drivers/mfd/tps65910.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index c1da84b..8517481 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -168,7 +168,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
goto err;

init_data->irq = pmic_plat_data->irq;
- init_data->irq_base = pmic_plat_data->irq;
+ init_data->irq_base = pmic_plat_data->irq_base;

tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);

Hi Samuel,
Any feedback on this patch?

Thanks,
Laxman



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/