Re: [PATCH 1/3] ahci: add AHCI_HFLAG_STRICT_SPEC host flag

From: Tejun Heo
Date: Mon Feb 20 2012 - 15:51:24 EST


Hello,

Overall the patchset looks good but

On Mon, Feb 20, 2012 at 12:09:21PM -0800, Brian Norris wrote:
> + AHCI_HFLAG_STRICT_SPEC = (1 << 15), /* strict AHCI spec */

can you please use something more specific? e.g. something like
SKIP_ENGINE_ON_PORT_START and then explain what the flag is about in
the comment?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/