Re: Linux 3.3-rc4

[H. Peter Anvin]

On 02/19/2012 12:02 PM, Linus Torvalds wrote:
> On Sun, Feb 19, 2012 at 11:49 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
>>
>> A real shame, this should have used "__aligned_u64" from the
>> beginning.
> 
> I agree. Sadly, this is exactly the kind of thing that is *really*
> easy to overlook, and once it is overlooked we're screwed because
> fixing it just breaks the native 32-bit case.
> 

I'm starting to think we should compile the kernel with -Wpadded by
default (currently it's only done at "warning level 3", which I doubt
anyone ever uses, especially since that also includes -Wpacked which is
an actively toxic warning) and force people to add explicit padding
where it needs to go, if necessary.  Unfortunately even that doesn't
guarantee compatibility with userspace, but it's at least something.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/