Re: [PATCH v2 19/19] ARM: at91/board-dt: move at91_initialize() toinit_irq()

[Jean-Christophe PLAGNIOL-VILLARD]

On 09:48 Wed 22 Feb     , Russell King - ARM Linux wrote:
> On Wed, Feb 22, 2012 at 10:39:45AM +0100, Nicolas Ferre wrote:
> > From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
> > 
> > Remove the need for at91_initialize() to be called at init_early().
> > We move it to init_irq() function as we still need it before the
> > timer initialization.
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
> > Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> 
> NAK.  Keep the callback methods pure.  The whole point of the init_early
> is so that soc people don't end up polluting things like the IRQ
> initialization and timer initialization with stuff like this.
> 
> So this is a backwards step.
ok we drop it in the pull

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/