Re: [PATCH 00/10] jump label: introduce very_[un]likely + cleanups +docs

[Ingo Molnar]

* H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> On 02/22/2012 12:18 AM, Ingo Molnar wrote:
> > 
> > For example could you tell *at a glance* what this does:
> > 
> > +       if (!static_branch_def_false(&perf_sched_events.key))
> > 
> > ?
> 
> Yes. [...]

You have specially built eyes I guess - congrats, you are member 
of the 1% :-)

> [...]  Unlike
> 
> > +       if (very_unlikely(&perf_sched_events.key))
> 
> ... which is actively misleading.

Misleading in what way? It clearly conveys that the slowpath 
that follows is a slowpath, that what follows is 'very 
unlikely'.

This is how all current kernel code is using these facilities.

If you have a new usecase (CPU feature flags) then you should 
outline that, instead of expecting something of current usecases 
that they are clearly not ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/