Re: [PATCH v2 12/19] ARM: at91/rtc-at91sam9: each SoC can selectthe RTT device to use

From: Jean-Christophe PLAGNIOL-VILLARD
Date: Wed Feb 22 2012 - 13:18:06 EST


On 17:25 Wed 22 Feb , Arnd Bergmann wrote:
> On Wednesday 22 February 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > But if you change the rtc driver to always bind to the existing
> > > "at91_rtt" platform_device and fail the probe() function for the
> > > case that you are on at91sam9263 probing the non-RTC device,
> > > you should get the exact same result without any extra code
> > > in the per-soc files.
> >
> > agreed but as on at91sam9263 you have 2 RTTs so you can have 2 drivers at the
> > same time that use the RTT. So we can not do this except if we set the second
> > RTT to an other device name.
>
> Let me rephrase what I meant then:
>
> The first driver should in its probe function do:
>
> if (pdev->id != CONFIG_RTC_DRV_AT91SAM9_RTT)
> return -ENODEV;
>
> while the other driver does
>
> if (pdev->id == CONFIG_RTC_DRV_AT91SAM9_RTT)
> return -ENODEV;
>
> This way, each driver binds to one device but not the other.
> It should even work with an unmodified second driver, as long
> as you guarantee that it's loaded after the first one.
>
> Any reason why this won't work?
just one other issue I need to pass the GPBR ressource to the RTC driver only

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/