Re: [PATCH] x86, efi: Fix unaligned access and endian issues

From: Stephen Rothwell
Date: Wed Feb 22 2012 - 18:55:06 EST


Hi Matt,

On Wed, 22 Feb 2012 22:58:28 +0000 Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote:
>
> Thanks Stephen, this bzImage works fine on my setup.

Great.

> > One little thing is that those two new functions may we warned about as
> > unused if CONFIG_EFI_STUB is not set (I have not done that build yet).
>
> Should be OK because they're static inline (it at least doesn't warn
> here).

And I did the build and they don;t warn here either, so good.

> Peter was talking about exporting unaligned.h for host tools so this
> patch will probably go through another iteration anyway.

OK. In that case, I will add this version to my fixes tree in linux-next
just so that the allmodconfig builds work again. I will remove it when
it turns up (presumably in the tip tree).

Just to be clear, it wasn't the unaligned accesses that were causing me a
problem (PowerPC copes), it was the endian issues.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature