Re: [PATCH] ext4: MMP: Fix endianness bug.

From: Johann Lombardi
Date: Thu Feb 23 2012 - 16:49:40 EST


On Fri, Feb 24, 2012 at 12:39:05AM +0530, santoshprasadnayak@xxxxxxxxx wrote:
> @@ -257,8 +257,8 @@ int ext4_multi_mount_protect(struct super_block *sb,
> * If check_interval in MMP block is larger, use that instead of
> * update_interval from the superblock.
> */
> - if (mmp->mmp_check_interval > mmp_check_interval)
> - mmp_check_interval = mmp->mmp_check_interval;
> + if (le16_to_cpu(mmp->mmp_check_interval) > mmp_check_interval)
> + mmp_check_interval = le16_to_cpu(mmp->mmp_check_interval);

Looks good to me.
Reviewed-by: Johann Lombardi <johann@xxxxxxxxxxxxx>

Johann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/