Re: [PATCH -v2 1/4] PCI: Add class support in quirk handling

From: Yinghai Lu
Date: Fri Feb 24 2012 - 01:40:16 EST


On Thu, Feb 23, 2012 at 12:44 PM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
>
> I like this series, a few comments:
>  - class and class_shift everywhere (in pci_fixup {} and the new
>    macros) for readability

ok.

>  - split the individual quirk fixes into separate patches (makes it
>    easier to revert or identify if one breaks)

yes

will send updated patches shortly.

>  - the reassigndev patch looks like a good one independent of the
>    series

yes, you can apply that separately.

Thanks

Yinghai
yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/