Re: [PATCH] oom: add sysctl to enable slab memory dump

From: Pekka Enberg
Date: Fri Feb 24 2012 - 01:57:41 EST


On Thu, 23 Feb 2012, David Rientjes wrote:
> > Great! So, why not letting the time tell us if this feature will be obsoleted
> > or not? I'd rather have this patch obsoleted by another one proven better, than
> > just stay still waiting for something that might, or might not, happen in the
> > future.
>
> Because (1) you're adding a sysctl that we don't want to obsolete and
> remove from the kernel that someone will come to depend on and then have
> to find an alternative solution like /dev/mem_notify, and (2) people parse
> messages like this that are emitted to the kernel log that we don't want
> to break in the future.
>
> So NACK on this approach.

Right. We should drop the sysctl and make it into a kernel command line
debugging option instead.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/