Re: [PATCH 00/10] jump label: introduce very_[un]likely + cleanups +docs

From: Ingo Molnar
Date: Fri Feb 24 2012 - 03:04:42 EST



* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> Seriously, I don't understand why you don't just use the
> obvious name. The data structure is named "static_key". The
> things that change it are named "static_key_inc()" or
> something. So a name like "static_key_true()" is simply
> *better*, isn't it?

Yes, you are right, in hindsight it's indeed obviously and
trivially better :-/

> It's not just about less confusion, it's actually about just
> having consistent naming.

Okay. I sent out the slightly reworked patch that gets rid of
this confusion and makes it all consistent.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/