Re: [patch] epoll: remove unneeded variable in reverse_path_check()

From: Jason Baron
Date: Fri Feb 24 2012 - 09:53:28 EST


On Fri, Feb 24, 2012 at 02:31:58PM +0300, Dan Carpenter wrote:
> We never use the length variable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/fs/eventpoll.c b/fs/eventpoll.c
> index c636fc8..997a6d2 100644
> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c
> @@ -1042,13 +1042,11 @@ static int reverse_path_check_proc(void *priv, void *cookie, int call_nests)
> */
> static int reverse_path_check(void)
> {
> - int length = 0;
> int error = 0;
> struct file *current_file;
>
> /* let's call this for all tfiles */
> list_for_each_entry(current_file, &tfile_check_list, f_tfile_llink) {
> - length++;
> path_count_init();
> error = ep_call_nested(&poll_loop_ncalls, EP_MAX_NESTS,
> reverse_path_check_proc, current_file,

Yes, I had that in there while testing, and should have removed it.

Acked-by: Jason Baron <jbaron@xxxxxxxxxx>

Thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/