Re: [PATCH 00/10] jump label: introduce very_[un]likely + cleanups+ docs

[Mathieu Desnoyers]

* Ingo Molnar (mingo@xxxxxxx) wrote:
[...]
> > [...] so we are going to have to change either the branch site 
> > or the test for true/false name. The above 
> > 'static_key_inline_true/false' solves that.
> 
> It's generally good practice to make the mostly commonly used 
> method names the simplest/shortest names - i.e. I don't think we 
> should make it longer via adding an _inline to every use.
> 
> In that sense static_key_true() has pretty optimal length - we'd 
> like these tests to also be visually unintrusive.
> 
> So in the latest patch (still under testing, will push it out 
> soon) we have:
> 
> 	static_key_true()
> 	static_key_false()
> 	static_key_enabled()

Hi Ingo,

Yes, I think your proposal makes sense. The "_inline_" would add lots of
typing for little clarity value. And I guess people will get used to
these constructs.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>

Thanks,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/