Re: [PATCH] ext4: MMP: Fix endianness bug.

[Andreas Dilger]

On 2012-02-23, at 12:09, santoshprasadnayak@xxxxxxxxx wrote:

> From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx>
> 
> Sparse complaint this endian bug in ext4: mmp.
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@xxxxxxxxx>

Looks good. 

Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>

> ---
> fs/ext4/mmp.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index 7ea4ba4..ed6548d 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -257,8 +257,8 @@ int ext4_multi_mount_protect(struct super_block *sb,
>     * If check_interval in MMP block is larger, use that instead of
>     * update_interval from the superblock.
>     */
> -    if (mmp->mmp_check_interval > mmp_check_interval)
> -        mmp_check_interval = mmp->mmp_check_interval;
> +    if (le16_to_cpu(mmp->mmp_check_interval) > mmp_check_interval)
> +        mmp_check_interval = le16_to_cpu(mmp->mmp_check_interval);
> 
>    seq = le32_to_cpu(mmp->mmp_seq);
>    if (seq == EXT4_MMP_SEQ_CLEAN)
> -- 
> 1.7.4.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/