Re: [PATCH 2/4] pch_uart: Add Fish River Island II uart clock quirks

From: Greg Kroah-Hartman
Date: Fri Feb 24 2012 - 16:55:48 EST


On Wed, Feb 22, 2012 at 01:46:06AM -0800, Darren Hart wrote:
>
>
> On 02/22/2012 12:52 AM, Alan Cox wrote:
> >> + /* Setup UART clock, checking for board specific clocks. */
> >> + uartclk = DEFAULT_UARTCLK;
> >> +
> >> + board_name = dmi_get_system_info(DMI_BOARD_NAME);
> >> + if (board_name && strstr(board_name, "CM-iTC"))
> >> + uartclk = CMITC_UARTCLK;
> >> +
> >> + board_name = dmi_get_system_info(DMI_PRODUCT_NAME);
> >> + if (board_name && strstr(board_name, "Fish River Island II"))
> >> + uartclk = FRI2_UARTCLK;
> >> +
> >> + port->uartclk = uartclk;
> >
> > This is confusing, you load product name into a variable called
> > board_name ?? perhaps "name" would be clearer ?
>
> OK, done.

"Done" where? Is there a newer patch series I should be looking at
here to apply? I'm guessing I can ignore this one, right?

consider it ignored :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/