Re: [PATCH 2/4] pch_uart: Add Fish River Island II uart clock quirks

[Greg Kroah-Hartman]

On Fri, Feb 24, 2012 at 02:25:47PM -0800, Darren Hart wrote:
> 
> 
> On 02/24/2012 01:53 PM, Greg Kroah-Hartman wrote:
> > On Wed, Feb 22, 2012 at 01:46:06AM -0800, Darren Hart wrote:
> >>
> >>
> >> On 02/22/2012 12:52 AM, Alan Cox wrote:
> >>>> +	/* Setup UART clock, checking for board specific clocks. */
> >>>> +	uartclk = DEFAULT_UARTCLK;
> >>>> +
> >>>> +	board_name = dmi_get_system_info(DMI_BOARD_NAME);
> >>>> +	if (board_name && strstr(board_name, "CM-iTC"))
> >>>> +		uartclk = CMITC_UARTCLK;
> >>>> +
> >>>> +	board_name = dmi_get_system_info(DMI_PRODUCT_NAME);
> >>>> +	if (board_name && strstr(board_name, "Fish River Island II"))
> >>>> +		uartclk = FRI2_UARTCLK;
> >>>> +
> >>>> +	port->uartclk = uartclk;
> >>>
> >>> This is confusing, you load product name into a variable called
> >>> board_name ?? perhaps "name" would be clearer ?
> >>
> >> OK, done.
> > 
> > "Done" where?  Is there a newer patch series I should be looking at
> > here to apply?  I'm guessing I can ignore this one, right?
> > 
> > consider it ignored :)
> 
> I have the V2 patch series here, tested it, was going to send it today
> .... then received a new revision of the hardware/firmware which hides
> the PCI device and the UART is driven by the 8250 driver and requires me
> to use 3318 as the baud ..... ***sigh***. I'm not sure what the right
> thing is to do right now. I'm going to have a conversation with the
> hardware manufacturer and the TWO firmware teams I'm working with.
> 
> If anyone has experience with this sort of mess and would like to offer
> a recommended course of action, I'm all ears.

A big stick is usually best to use on the firmware engineers...

Good luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/