Re: "whitespace coding style cleanup" broke coding style

From: Tilman Schmidt
Date: Tue Feb 28 2012 - 12:59:17 EST


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 27.02.2012 17:52, Joe Perches wrote:
> On Mon, 2012-02-27 at 09:59 +0100, Jiri Slaby wrote:
>> commit 475be4d85a274d0961593db41cf85689db1d583c
>> Author: Joe Perches <joe@xxxxxxxxxxx>
>> Date: Sun Feb 19 19:52:38 2012 -0800
>>
>> isdn: whitespace coding style cleanup
>>
>> isdn source code uses a not-current coding style.
[...]
> It was a first pass and an overall improvement.

I'm not so sure about that, but I'm probably biased.

What grieves me more is how that patch was sneaked in without any
notification to the maintainers of the code in question. With the
customary CC, we could have caught the problems before they reached
- -next.

> I'm working on improving the logging style
> in isdn and will submit more patches soonish.

Please remember to CC the maintainers of the affected code this time.

Thanks,
Tilman

- --
Tilman Schmidt E-Mail: tilman@xxxxxxx
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
UngeÃffnet mindestens haltbar bis: (siehe RÃckseite)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk9NFeEACgkQQ3+did9BuFvG2ACdGL+9IMooAmMAlJwON2kHU+f8
2V4AnjjdZDNwaNGQuLVRKS100TfG6i+e
=FKIs
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/