Re: [PATCH 2/2] OpenRISC: IRQ: Include module.h

From: Jonas Bonn
Date: Wed Feb 29 2012 - 02:49:09 EST



Thanks. There is already a patch in linux-next for this.

However, the patch in linux-next pulls in export.h instead of module.h.
I think export.h is the correct header file to be using here, but let me
know if you see it differently.

Thanks for helping out with build-testing the OpenRISC arch... much
appreciated.

/Jonas

On Wed, 2012-02-29 at 01:46 +0100, Richard Weinberger wrote:
> Fixes:
> CC arch/openrisc/kernel/irq.o
> arch/openrisc/kernel/irq.c:35:1: warning: data definition has no type or storage class
> arch/openrisc/kernel/irq.c:35:1: warning: type defaults to âintâ in declaration of âEXPORT_SYMBOLâ
> arch/openrisc/kernel/irq.c:35:1: warning: parameter names (without types) in function declaration
> arch/openrisc/kernel/irq.c:42:1: warning: data definition has no type or storage class
> arch/openrisc/kernel/irq.c:42:1: warning: type defaults to âintâ in declaration of âEXPORT_SYMBOLâ
> arch/openrisc/kernel/irq.c:42:1: warning: parameter names (without types) in function declaration
> arch/openrisc/kernel/irq.c:173:1: warning: data definition has no type or storage class
> arch/openrisc/kernel/irq.c:173:1: warning: type defaults to âintâ in declaration of âEXPORT_SYMBOL_GPLâ
> arch/openrisc/kernel/irq.c:173:1: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
> arch/openrisc/kernel/irq.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/openrisc/kernel/irq.c b/arch/openrisc/kernel/irq.c
> index 59b3023..f917925 100644
> --- a/arch/openrisc/kernel/irq.c
> +++ b/arch/openrisc/kernel/irq.c
> @@ -14,6 +14,7 @@
> * 2 of the License, or (at your option) any later version.
> */
>
> +#include <linux/module.h>
> #include <linux/ptrace.h>
> #include <linux/errno.h>
> #include <linux/interrupt.h>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/