Re: [PATCH v9 1/2] ARM: EXYNOS: Change System MMU platform devicedefinitions

[Sylwester Nawrocki]

Hello,

On 02/29/2012 01:25 AM, KyongHo Cho wrote:
>>>  static int exynos4_clk_hdmiphy_ctrl(struct clk *clk, int enable)
>>>  {
>>>       return s5p_gatectrl(S5P_HDMI_PHY_CONTROL, clk, enable);
>>> @@ -679,61 +684,55 @@ static struct clk exynos4_init_clocks_off[] = {
>>>               .enable         = exynos4_clk_ip_peril_ctrl,
>>>               .ctrlbit        = (1 << 14),
>>>       }, {
>>> -             .name           = "SYSMMU_MDMA",
>>> +             .name           = SYSMMU_CLOCK_NAME,
>>> +             .devname        = SYSMMU_CLOCK_DEVNAME(mfc_l, 0),
>>> +             .enable         = exynos4_clk_ip_mfc_ctrl,
>>> +             .ctrlbit        = (1 << 1),
>>> +     }, {
>>> +             .name           = SYSMMU_CLOCK_NAME,
>>> +             .devname        = SYSMMU_CLOCK_DEVNAME(mfc_r, 1),
>>> +             .enable         = exynos4_clk_ip_mfc_ctrl,
>>> +             .ctrlbit        = (1 << 2),
>>> +     }, {
>>> +             .name           = SYSMMU_CLOCK_NAME,
>>> +             .devname        = SYSMMU_CLOCK_DEVNAME(tv, 2),
>>> +             .enable         = exynos4_clk_ip_tv_ctrl,
>>> +             .ctrlbit        = (1 << 4),
>>> +     }, {
>>> +             .name           = SYSMMU_CLOCK_NAME,
>>> +             .devname        = SYSMMU_CLOCK_DEVNAME(jpeg, 3),
>>> +             .enable         = exynos4_clk_ip_cam_ctrl,
>>> +             .ctrlbit        = (1 << 11),
>>> +     }, {
>>> +             .name           = SYSMMU_CLOCK_NAME,
>>> +             .devname        = SYSMMU_CLOCK_DEVNAME(rot, 4),
>>>               .enable         = exynos4_clk_ip_image_ctrl,
>>> -             .ctrlbit        = (1 << 5),
>>> +             .ctrlbit        = (1 << 4),
>>>       }, {
>>> -             .name           = "SYSMMU_FIMC0",
>>> +             .name           = SYSMMU_CLOCK_NAME,
>>> +             .devname        = SYSMMU_CLOCK_DEVNAME(gsc0, 5),
>> It's exynos4 series clock and don't have gsc name. I don't know LSI
>> decides to use gsc instead of fimc for both exynos4 and exynos5. but
>> there's no name gsc at Spec..
> 
> gsc0 is just a name of the platform device of FIMC0 in Exynos4.

I think it's not right what you're saying. Gscalers first appeared only
in exynos5 (at least according to all specifications I have) and you already
have the corresponding change for clock-exynos5.c. FIMCs in exynos 4210, 4212
and 4412 are almost not changed, so please don't rename like this, which is 
confusing. If you need common clkdev entries for the exynos4 and exynos5 
devices, then the "devname"s above might need to be removed and required 
clock entries should be created through the CLKDEV_INIT() macro.

> It is also used for GSclaler0 in Exynos5.
> I wanted to reduce waste of platform device definitions that do not exist
> in an application processor.
> 
> If it looks confused, I will find another way.

Thanks,
-- 
Sylwester Nawrocki
Samsung Poland R&D Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/