Re: [Bug #42707] Hang deconfiguring network interface (inshutdown) on 3.3-rc1

From: David Miller
Date: Wed Feb 29 2012 - 13:47:11 EST


From: "Michael Chan" <mchan@xxxxxxxxxxxx>
Date: Wed, 29 Feb 2012 01:33:37 -0800

> Subject: [PATCH net] tg3: Fix tg3_get_stats64 for 5700 / 5701 devs
>
> From: Matt Carlson <mcarlson@xxxxxxxxxxxx>
>
> tg3_get_stats64() takes tp->lock when dealing with non-serdes bcm5700
> and bcm5701 devices. However, functions that call tg3_halt() have
> already acquired tp->lock. When tg3_get_stats64() is called in
> tg3_halt(), deadlock will occur.
>
> This patch fixes the problem by separating the stat gathering code into
> a new tg3_get_nstats() function. tg3_get_stats64() is recoded to call
> this function and take tp->lock. The code that takes tp->lock in
> tg3_calc_crc_errors() has been removed. Function signatures have been
> cleaned up too.
>
> Signed-off-by: Matt Carlson <mcarlson@xxxxxxxxxxxx>
> Signed-off-by: Michael Chan <mchan@xxxxxxxxxxxx>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/