Re: [RFC/RFT 5/5] p54spi: Load firmware from work queue and not fromprobe routine

[Larry Finger]

On 02/29/2012 01:54 PM, Max Filippov wrote:
> > > Drivers that load firmware from their probe routine have problems with the
> > > latest versions of udev as they get timeouts while waiting for user
> > > space to start. The problem is fixed by loading the firmware and starting
> > > mac80211 from a delayed_work queue. By using this method, most of the
> > > original code is preserved.
> > >
> > > Signed-off-by: Larry Finger<Larry.Finger@xxxxxxxxxxxx>
> > > ---
> > > This one is compile-tested only.
> > >
> > > Larry
> > > ---
> >
> >
> > Any testing done here?
>
> insmod immediately followed by rmmod causes NULL pointer dereference.
> The same always happens on rmmode when the firmware image is absent:

Thanks for testing.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/