Re: [PATCH 2/3] x86, RAS: Add a decoded msg buffer

From: Borislav Petkov
Date: Fri Mar 02 2012 - 04:56:07 EST


On Wed, Feb 29, 2012 at 11:11:46AM +0100, Borislav Petkov wrote:
> > Is there some upper bound for how long this string can get? Why not
> > just allocate a generous amount at boot time?
>
> Yep, this sounds like the easiest thing to do, let me play with MCE
> injection a bit.

So I left it inject all kinds of errors overnight and the buffer got
enlarged to 400 bytes:

[ 1115.162484] Buffer enlarged to 250
[ 1115.166059] Buffer enlarged to 300
[ 1115.169604] Buffer enlarged to 350
[ 3855.129854] Buffer enlarged to 400

So I'm guessing something like 500 bytes would be a safe bet in the
current situation.

Now whether 500 bytes is a lot or not, dunno, we'll see how it plays
out in testing. Also, the question is what would happen if we need to
enlarge it later for some more info, hm. Maybe I should go over the
decoded strings and try slimming them up a bit...

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/