Re: [patch] dma-debug: debugfs_create_bool() takes a u32 pointer

[Dan Carpenter]

On Fri, Mar 02, 2012 at 06:22:03AM -0500, Neil Horman wrote:
> This certainly works, but a quick search of call sites shows this isn't the only
> place someone passes a bool to debugfs_create_bool. I think the better solution
> would be to change debugfs_create_bool and its corresponding read/write methods
> to actually work with a bool type, and then clean all the call sites to pass in
> a bool properly, instead of a u32.

There is only one other call site which gets this wrong, and I sent
a fix for that today as well.  But yes, you're probably right that
would be cleaner.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature