Re: [RFC patch] spindep: add cross cache lines checking

[Ingo Molnar]

* Arnd Bergmann <arnd@xxxxxxxx> wrote:

> On Monday 05 March 2012, Alex Shi wrote:
> > Subject: [PATCH] lockdep: add cross cache lines checking
> > 
> > Modern x86 CPU won't hold whole memory bus when executing 
> > 'lock' prefixed instructions unless the instruction 
> > destination is crossing 2 cache lines. If so, it is disaster 
> > of system performance.
> > 
> > Actually if the lock is not in the 'packed' structure, gcc 
> > places it safely under x86 arch. But seems add this checking 
> > in CONFIG_DEBUG_LOCK_ALLOC is harmless.
> 
> Have you tried making this a compile-time check using 
> __alignof__? I would say that any spinlock in a packed data 
> structure is basically a bug, even more so on most other 
> architectures besides x86.

agreed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/