Re: [PATCH v2] block: avoid false positive warnings on ioctl to partition

From: Paolo Bonzini
Date: Tue Mar 06 2012 - 06:35:15 EST


Il 29/02/2012 01:14, Linus Torvalds ha scritto:
> So I'm still not convinced this is safe, and feel a bit worried about
> us possibly silently missing some things. That
>
> default:
> return -ENOIOCTLCMD;
>
> is what worries me.
>
> Blocking the ones we *know* about and understand I'm perfectly fine
> with. And the SG_IO case looks fine. It's the possibly unknown users
> that still worry me.

Are you okay with applying this at the beginning of the next merge window?

My worry is that people get desensitized to the warnings. As time
passes, the likelihood decreases that an actual problem is reported.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/