Re: [PATCH/RFC 2/2] arm/tegra: add timeout to PCIe PLL lock detectionloop

From: Stephen Warren
Date: Tue Mar 06 2012 - 12:06:04 EST


On 03/06/2012 01:45 AM, Dmitry Artamonow wrote:
> Tegra PCIe driver waits for PLL to lock using busy loop.
> If PLL fails to lock for some reason, this leads to silent lockup
> while booting (as PCIe code is not modular).
>
> Fix by adding timeout, so if PLL doesn't lock in a couple
> of seconds, just PCIe driver fails and machine continues to boot.
>
> Signed-off-by: Dmitry Artamonow <mad_soft@xxxxxxxx>

That seems reasonable. So once the mdelay discussion is resolved,

Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx>

Any idea why the PLL doesn't lock sometimes?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/