Re: [PATCH 08/13] android: persistent_ram: handle reserving andmapping memory

[John Stultz]

On Wed, 2012-03-07 at 14:08 -0800, Greg KH wrote:
> On Wed, Mar 07, 2012 at 01:58:18PM -0800, John Stultz wrote:
> > From: Colin Cross <ccross@xxxxxxxxxxx>
> > 
> > Replace the ioremapped memory passed in from the drivers with
> > a memblock_reserve and vmap.  Adds a new function,
> > persistent_ram_early_init, designed to be called from the machine
> > init_early callback, that calls memblock_remove and saves the
> > provided persistent ram area layout.
> > 
> > Drivers only pass in their struct device * and ecc settings.
> > Locating and mapping the memory is now handled entirely within
> > persistent_ram.
> > 
> > Also, convert ram_console to the new persistent_ram_init
> > parameters that only take a struct device * and ecc settings.
> > 
> > CC: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > CC: Android Kernel Team <kernel-team@xxxxxxxxxxx>
> > Change-Id: Ibc87ec27b70ed1c928eaa487503469e199973058
> > Change-Id: I12b018381a2ed5965a8a4b0da40c3e640f92b6cf
> > Signed-off-by: Colin Cross <ccross@xxxxxxxxxxx>
> > [jstultz: Fix pr_info casting issues on 64bit, folded two
> > patches as the build breaks if they are apart. Also replaced
> > phys_to_page() w/ pfn_to_page(addr>>PAGE_SHIFT), as phys_to_page
> > is only on a few arches.]
> 
> Please put your comments above the signed-off-by area, it makes it
> easier on tools that parse this area.

I can change it, but this is how SubmittingPatches suggests it be done:

Signed-off-by: Random J Developer <random@xxxxxxxxxxxxxxxxxxxxx>
[lucky@xxxxxxxxxxxxxxxxxxxxxx: struct foo moved from foo.c to foo.h]
Signed-off-by: Lucky K Maintainer <lucky@xxxxxxxxxxxxxxxxxxxxxx>

thanks
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/