Re: [PATCH v2 0/3] cgroup: add xattr support

From: Li Zefan
Date: Thu Mar 08 2012 - 04:00:49 EST


Tejun Heo wrote:
> Hello, Li.
>
> Sorry about the delay. Was on vacation.
>

Me too. ;)

> On Thu, Mar 01, 2012 at 02:16:57PM +0800, Li Zefan wrote:
>> This can be used to attach metadata to a cgroup, which is required
>> by systemd.
>>
>> As lazy as I am, here just quoted from Lennart for the detailed use
>> cases:
>
> I much prefer this version but would prefer to deal with this in the
> next merge window as we're already on rc6. On a cursory look...
>

I'm fine with this, especially I'm busy with other stuff.

> * I'm not sure kmem_ is a good prefix. It sucks that xattr values are
> stored in kmem w/o size limit and we probably want to improve on
> both fronts in the future. Wouldn't it be better to name them
> simple_*() and put them in fs/libfs.c?
>

Ok.

> * I don't think we want CONFIG option for cgroupfs xattr. Let's just
> add a mount option.

Ok.

>
> Thanks.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/