Re: [PATCH 06/23] PCI: rescan with bus or bridge using callbackmethod too

[Yinghai Lu]

On Fri, Mar 9, 2012 at 9:22 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>
> Why did you just repeat my proposal, changing "err" to "ret"?  I
> missed the point you're trying to make.  The name "err" gives an
> important clue that device_schedule_callback() returns 0 or errno.
> That's essential to understanding the code.
>
> Your original patch has one "return."  Mine proposal has three.  All
> that means is that the reader of your patch has to manage more stuff
> in her head to understand the code.  That's not a benefit!

ok, can we have separated patch to fix them all?

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/