Re: [PATCH 1/9] exec: add a global execve counter

[Djalal Harouni]

On Sun, Mar 11, 2012 at 06:25:12PM +0100, Oleg Nesterov wrote:
> On 03/11, Djalal Harouni wrote:
> >
> > --- a/include/linux/sched.h
> > +++ b/include/linux/sched.h
> > @@ -1420,6 +1420,9 @@ struct task_struct {
> >  #endif
> >  	seccomp_t seccomp;
> >
> > +/* Execve counter: will be used to check if objects belong to the appropriate
> > + * process image */
> > +	atomic64_t exec_id;
> >  /* Thread group tracking */
> >     	u32 parent_exec_id;
> >     	u32 self_exec_id;
> 
> Well, I don't think it is right to add this counter into task_struct.
> 
> It should be per-process, signal_struct makes more sense. Or may be
> mm_struct.
Some /proc/<pid>/{syscall,stack,...} do not operate on mm_struct so why we
should add the: "acquire a reference to mm, get exec_id and mmput".

For the signal_struct currently I don't know, from a comment it seems that
signal_struct can be shared! I don't know.

> Btw this is also true for parent_exec_id/self_exec_id, but this is
> another story.
Yes someone who knows this should check it.

> Oleg.
Thanks.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
tixxdz
http://opendz.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/