Re: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.

From: David Miller
Date: Mon Mar 12 2012 - 05:37:14 EST


From: santosh prasad nayak <santoshprasadnayak@xxxxxxxxx>
Date: Mon, 12 Mar 2012 14:45:38 +0530

> Subject: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.
>
> Change the datatype of "ip_addr" to __be32 as 'ip' should be in
> big endian format.
>
> Adapter needs "ip address" in big endian format stored at lower 32bit
> of req.word[1]. netxen_config_ipaddr() now receives 'ip' in big endian
> format. To satisfy adapter's need, use memcpy() to copy byte by byte
> of 'ip' into lower 32bit of req.word[1].
>
> Mac address and serial number of adapter need to be in little endian format.
> Change the data type of the related variables to __le32 / __le64 or cast it
> explicitly to __le32 / __le64 depending upon the requirement.

This looks a lot better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/