Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

From: Mark Brown
Date: Wed Mar 14 2012 - 13:29:26 EST


On Tue, Mar 13, 2012 at 05:54:38PM +0100, Karol Lewandowski wrote:

> - replace s3c24xx_i2c_type enum with plain unsigned int that can
> hold not only device type but also hw revision-specific quirks

Would it not be clearer to just have explicit flags for the quirks (eg,
as a set of bitfield flags)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/