Re: [PATCH] power, max8998: Include linux/module.h just once indrivers/power/max8998_charger.c

From: Jesper Juhl
Date: Thu Mar 15 2012 - 16:55:23 EST


On Thu, 15 Mar 2012, Paul Gortmaker wrote:

> On 12-03-15 01:17 PM, Anton Vorontsov wrote:
> > On Mon, Feb 06, 2012 at 01:57:54AM +0000, íëì wrote:
> >>> Remove the duplicate.
> >>>
> >>> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> >>
> >> Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> >
> > Applied, thanks!
>
> There is already a commit queued in linux-next that deletes
> all the duplicates at once. It just so happens to delete
> the other instance vs the one shown here. So if both
> commits are present, then there won't be *any* module.h
> left, and the build will fail. If it is possible, please
> just drop this patch, since the treewide duplicate patch
> will still have to exist to fix the other instances.
>
> https://lkml.org/lkml/2012/2/29/586
>

I agree. Drop this one.

--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.