[PATCH -v3 38/47] PCI, sysfs: Prepare to kill pci device rescan

From: Yinghai Lu
Date: Mon Mar 19 2012 - 01:57:53 EST


Hope we can kill it after one year.

Print warning to catch real users for that feature.

Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
---
Documentation/feature-removal-schedule.txt | 9 +++++++++
drivers/pci/pci-sysfs.c | 3 +++
2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index a0ffac0..1b984a1 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -299,6 +299,15 @@ Why: In 2.6.27, the semantics of /sys/bus/pci/slots was redefined to
fakephp interface.
Who: Alex Chiang <achiang@xxxxxx>

+-----------------------------
+
+What: /sys/bus/pci/devices/.../rescan
+When: April 2013
+Why: That rescan will rescan pci parent's bus. It is confusing.
+ Now we have bridge rescan_bridge and bus rescan, and they could
+ be used on exact device and bus that need to be rescaned.
+Who: Yinghai Lu <yinghai@xxxxxxxxxx>
+
---------------------------

What: CONFIG_RFKILL_INPUT
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 4697afe..d33a1bc 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -318,6 +318,9 @@ dev_rescan_store(struct device *dev, struct device_attribute *attr,
return -EINVAL;

if (val) {
+ printk(KERN_WARNING "rescan with pci device will be removed "
+ "shortly, please use bridge rescan_bridge\n"
+ "or bus/rescan instead\n");
mutex_lock(&pci_remove_rescan_mutex);
pci_rescan_bus(pdev->bus);
mutex_unlock(&pci_remove_rescan_mutex);
--
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/