Re: [PATCH 06/10] cgroup: convert memcg controller to the newcftype interface

From: Tejun Heo
Date: Mon Mar 19 2012 - 12:11:00 EST


Hello,

On Mon, Mar 19, 2012 at 01:26:02PM +0900, KAMEZAWA Hiroyuki wrote:
> > +CGROUP_SUBSYS_CFTYPES_COND(mem_cgroup_subsys, memsw_cgroup_files,
> > + really_do_swap_account);
>
>
> I'm sorry but why you use really_do_swap_account instead of do_swap_account ?

Because do_swap_account is initialized too late.
CGROUP_SUBSYS_CFTYPES() are processed via fs_initcall(). AFAICS,
do_swap_account may not have been initialized by then. Also, if memcg
as whole is disabled, it doesn't matter whether those files are
registered or not, right? We probably need some comment there tho.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/