Re: [PATCH net V4] bonding: send igmp report for its master

From: David Miller
Date: Mon Mar 19 2012 - 18:06:33 EST


From: Weiping Pan <panweiping3@xxxxxxxxx>
Date: Sun, 18 Mar 2012 11:23:27 +0800

> Liang Zheng(lzheng@xxxxxxxxxx) found that in the following topo,
> bonding does not send igmp report when we trigger a fail-over of bonding.
>
> eth0--
> |-- bond0 -- br0
> eth1--
>
> modprobe bonding mode=1 miimon=100 resend_igmp=10
> ifconfig bond0 up
> ifenslave bond0 eth0 eth1
>
> brctl addbr br0
> ifconfig br0 192.168.100.2/24 up
> brctl addif br0 bond0
>
> Add 192.168.100.2(br0) into a multicast group, like 224.10.10.10,
> then trigger a fali-over in bonding.
> You can see that parameter "resend_igmp" does not work.
>
> The reason is that when we add br0 into a multicast group,
> it does not propagate multicast knowledge down to its ports.
>
> If we choose to propagate multicast knowledge down to all ports for bridge,
> then we have to track every change that is done to bridge, and keep a backup
> for all ports. It is hard to track, I think.
>
> Instead I choose to modify bonding to send igmp report for its master.
>
> Changelog:
> V2: correct comments
> V3: move this check into bond_resend_igmp_join_requests()
> V4: only send igmp reports if bond is enslaved to a bridge
>
> Signed-off-by: Weiping Pan <panweiping3@xxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/