Re: [PATCH] fs: Fix mod_timer crash when removing USB sticks

[Paul Taysom]

On Mon, Mar 19, 2012 at 7:02 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, 19 Mar 2012, Paul Taysom wrote:
>
>> I have rerun my tests without my change on the 3.2.7 kernel and I was
>> not able to get it to crash. I even put some code in to do the early
>> detection so I didn't have to wait for another thread to stumble
>> across the corruption. The way I test is with several flash drivers
>> with ext2, ext3, ext4, FAT, and HPFS file systems and just repeatedly
>> plug and unplug them. When a flash drive is plugged in with a file
>> system, it is automatically mounted.
>
> That's not the right way to test a race like this.  The right way is to
> insert ssleep() calls at some appropriate spots, so that you can force
> the race to come out the way you want every time.
>
> What about the question of resetting the bdi pointer at the same time
> as some other thread is using it?  Have you tested whether Mandeep's
> locking suggestion will prevent problems?
>
> Alan Stern
>

The checks I added to timer.c seems to the defect every time. With
3.2.7, it never sees the defect.
Paul Taysom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/