Re: [PATCH] e1000e: clear REQ and GNT in EECD (82571 && 82572)

From: Jeff Kirsher
Date: Sat Mar 24 2012 - 05:14:00 EST


On Fri, 2012-03-23 at 13:55 +0100, Richard Alpe wrote:
> Clear the REQ and GNT bit in the eeprom control register (EECD).
> This is required if the eeprom is to be accessed with auto read
> EERD register.
>
> After a cold reset this doesn't matter but if PBIST MAC test was
> executed before booting, the register was left in a dirty state
> (the 2 bits where set), which caused the read operation to time out
> and returning 0.
>
> Reference (page 312):
> http://download.intel.com/design/network/manuals/316080.pdf
>
> Reported-by: Aleksandar Igic <aleksandar.igic@xxxxxxxxxxxxxx>
> Signed-off-by: Richard Alpe <richard.alpe@xxxxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/e1000e/82571.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)

Thank you, I will add the patch to my queue.

Attachment: signature.asc
Description: This is a digitally signed message part