Re: [PATCH] ext2: Don't export ext2_mask_flags() to user space

From: Mike Frysinger
Date: Sat Mar 24 2012 - 13:59:34 EST

On Saturday 24 March 2012 04:37:56 Al Viro wrote:
> On Sat, Mar 24, 2012 at 02:50:38AM -0400, Mike Frysinger wrote:
> > > and that's it. ??blackfin and do_mounts_rd are doing the same thing
> > > (blackfin - buggy, AFAICS).
> >
> > buggy how ? they're not exactly the same as the Blackfin code is
> > setting things up for the uClinux MTD map. it isn't parsing the
> > filesystem itself (ignoring the size extraction from the superblock).
> Compare and you'll see... Block size on ext2 may be bigger than 1Kb;
> ->s_log_block_size gives the shift (1Kb -> 0, 2Kb -> 1, etc.) Offset
> 0x18 in superblock, __le32...

fair enough. the users of the Blackfin code should generally be OK though due
to the constrained inputs and runtime systems.

> Anyway, I've pushed that into vfs.git#master along with other minor stuff
> right now; the last 5 commits in there are handling of ext2 and ext3
> headers, starting with "ext2: No longer export ext2_fs.h to user space" by
> Thierry Reding, with the next 3 after it doing the move and trimming...
> Should propagate to in a few.

looks good to me
Acked-by: Mike Frysinger <vapier@xxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part.