Re: [PATCH 05/11] m68k/atari: Add missing platform check beforeregistering platform devices

From: Michael Schmitz
Date: Sun Mar 25 2012 - 14:53:51 EST

Hi Geert,

>> How about this instead - probe for the EtherNAT config register, and
>> register devices only if found?
> That's even better, but logically, it's an extra change on top, so I'd like
> to keep it separate.

OK, I'll resend as soon as I've pulled your latest changes.

>> +    if (MACH_IS_ATARI) {
> I prefer the "if (!MACH_IS_ATARI) return -ENODEV;" at the top, as it
>  - means less code to change if more platform devices are added,
>  - means less source code to keep on your mental stack when reading the code,
>  - decreases indentation for the rest of the function.

OK; do you want the tests and platform calls conditional on config
options (we only need to have the platform data available if there's a
driver or module built to use it)?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at