Re: [patch] Move CRC computation to separate function
From: Artem Bityutskiy
Date: Mon Mar 26 2012 - 11:31:44 EST
On Sun, 2012-03-25 at 22:38 +0200, Joel Reardon wrote:
> CRC computation now an inline header function which will be used in
> multiple places in the future.
This will make git-am ignore Signed-off-by. Also, please, subject UBIFS
patches with an "UBIFS:" prefix. The good way to send a patch is to use
git format-patch and then git send-email or just insert it to the
message body as-is.
The best way to make sure you send patches correctly is to send to
yourself, then save, then try to apply with 'git am' and look at the
> Signed-off-by: Joel Reardon <reardonj@xxxxxxxxxxx>
> fs/ubifs/io.c | 4 +---
> fs/ubifs/misc.h | 15 +++++++++++++++
> 2 files changed, 16 insertions(+), 3 deletions(-)
> + * ubifs_set_crc - computes and writes the crc for a ubifs node to the common
> + * header.
> + * @node: the data node
> + */
The comment is not good. I've amended it and pushed the patch, thanks!
> +static inline void ubifs_set_node_crc(void *node)
Description: This is a digitally signed message part