Re: [PATCH 19/20 v2] sparc/mm/fault_32.c: Port OOM changes to do_sparc_fault
From: Kautuk Consul
Date: Mon Mar 26 2012 - 11:35:56 EST
On Sun, Mar 25, 2012 at 3:04 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Kautuk Consul <consul.kautuk@xxxxxxxxx>
> Date: Sun, 25 Mar 2012 13:58:35 -0400
>> + unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
>> + (write ? FAULT_FLAG_WRITE : 0));
> Still indented wrong, it should be:
> unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
> (write ? FAULT_FLAG_WRITE : 0));
> The second line must have the openning parenthesis line up with
> the column after the openning parenthesis on the first line. Do
> not use only tabs to indent this stuff, line it up properly.
> You need to use tabs and spaces to line it up. Use something like
> emacs's C-mode to help you if you can't do it right by hand.
>> + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
>> + 1, regs, address);
> Still wrong, for the same exact reason.
> I went out of my way to reply to your private email (which I usually
> ignore, you should never email developers privately) and you didn't
> even listen to the feedback I gave you.
I use gmail which did not show me the indentation which you wanted.
I understand what you said now and have sent a v3 for this.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/