Re: [PATCH v4] x86, olpc: add debugfs interface for EC commands
From: Paul Fox
Date: Mon Mar 26 2012 - 18:21:09 EST
> On Mon, 26 Mar 2012 19:07:07 +0100 (BST)
> Daniel Drake <dsd@xxxxxxxxxx> wrote:
> > Add a debugfs interface for sending commands to the OLPC Embedded
> > Controller (EC) and reading the responses. The EC provides functionality
> > for machine identification, battery and AC control, wakeup control, etc.
> > Having a debugfs interface available is useful for EC development and
> > debugging.
> > Based on code by Paul Fox.
> > Signed-off-by: Daniel Drake <dsd@xxxxxxxxxx>
> > Originally-from: Paul Fox <pgf@xxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> > Cc: Andres Salomon <dilinger@xxxxxxxxxx>
> > ...
> > v4: really fix sign-off tags
> s/fix/break/? "Originally-from" is not a recognised tag. If this code
> is based upon an earlier version from Paul then Signed-off-by: is
> What's going on here? What are you trying to communicate?
i think the way daniel had it before was likely correct.
i wrote the original code, but it looked pretty different back then.
daniel has brought it to its current state. i _then_ added my
so the code is both "Based on code by Paul Fox", and my Signed-off-by
should come after daniel's (assuming chronological order).
paul fox, pgf@xxxxxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/