Re: [PATCH v4] x86, olpc: add debugfs interface for EC commands
From: Ingo Molnar
Date: Mon Mar 26 2012 - 19:49:55 EST
* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 27 Mar 2012 01:14:08 +0200
> Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> > * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > > Signed-off-by: Daniel Drake <dsd@xxxxxxxxxx>
> > > > Originally-from: Paul Fox <pgf@xxxxxxxxxx>
> > > > Cc: Ingo Molnar <mingo@xxxxxxx>
> > > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > > > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> > > > Cc: Andres Salomon <dilinger@xxxxxxxxxx>
> > > >
> > > > ...
> > > >
> > > > v4: really fix sign-off tags
> > >
> > > s/fix/break/? "Originally-from" is not a recognised tag. If this code
> > > is based upon an earlier version from Paul then Signed-off-by: is
> > > correct.
> > No, the original ordering was *not* correct:
> > From: Daniel Drake <dsd@xxxxxxxxxx>
> > [...]
> > Signed-off-by: Daniel Drake <dsd@xxxxxxxxxx>
> > Signed-off-by: Paul Fox <pgf@xxxxxxxxxx>
> > In the previous discussion we had I explained what the rules for
> > signoffs are. Let me quote Linus as well:
> > " The sign-off chain should be very simple: the first person
> > to sign off should be the author, and the last person to
> > sign off should be the committer. "
> > https://lkml.org/lkml/2012/3/22/489
> > This is not true for this patch, because the first signoff does
> > not match the 'From:' line (author).
> > Nor is the last signoff the committer - i.e. the person sending
> > me this patch to apply. Every maintainer along the route adds a
> > signoff to the tail if it's propagated via email, or does a
> > merge commit if it's a pull.
> > If Daniel sends me a patch he should be the last signoff. If he
> > authored the patch then he should also be the first (and, by
> > implication, only) signoff. Signed-off-by does not recognize
> > multiple authorship - that has to be written into the changelog,
> > added via another type of tag - either approach is fine to me.
> That's a bunch of stuff which you and Linus apparently cooked
> up and didn't tell anyone about and didn't document anywhere.
I certainly didn't cook it up with Linus, and I think it's
pretty clearly written down in SubmittingPatches:
Signed-off-by: Random J Developer <random@xxxxxxxxxxxxxxxxxxxxx>
[lucky@xxxxxxxxxxxxxxxxxxxxxx: struct foo moved from foo.c to foo.h]
Signed-off-by: Lucky K Maintainer <lucky@xxxxxxxxxxxxxxxxxxxxxx>
It even describes how maintainers append themselves to after the
existing Signed-off-by chain - and describes how the author of
the patch adds the first Signed-off-by.
So I think it's pretty clearly defined.
> [...] I'd never heard about it before and I doubt if many
> other people knew about it. And if anyone should have known
> about it, I should have!
> So we have an unknown but probably large number of patches in
> the tree now which do not follow this rule. [...]
I think all the major Git trees are doing it the way described
in SubmittingPatches: first signoff is author and maintainers
append a Signed-off-by to the end.
In practice there's a large number of noise in the tree through,
as with any information created by humans, to be read by humans
and not checked by computers. But this does not justify the
intentional creation of noise I think.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/