Re: CPU Hotplug rework
From: Rusty Russell
Date: Mon Mar 26 2012 - 22:51:51 EST
On Mon, 26 Mar 2012 13:05:41 -0400, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Mon, 2012-03-26 at 18:13 +0200, Peter Zijlstra wrote:
> > On Mon, 2012-03-26 at 11:22 -0400, Steven Rostedt wrote:
> > So how about we add another variant of kthread_freezable_should_stop(),
> > maybe call it kthread_bound_should_stop() that checks if the cpu its
> > bound to goes awol, if so, park it.
> Do you mean to have this function automate the "park". When it is
> called, if the cpu is going down it should simply schedule off and not
> return until the CPU comes back on line?
> Actually, why not just keep "kthread_should_stop()" and instead create a
> "kthread_park()", and call that instead of kthread_stop(). Then when the
> task calls kthread_should_stop(), that can park the thread then.
Do we ever have to do this? Why not say we never move kthreads, and if
anyone really needs this, they have to do it themselves.
We *will* need a way for the kthreads to say "don't take this cpu away
now" in a v. lightweight way, but I'm happy with the -rt solution that
Basically, it's time to revisit cpu hotplug entirely. Let's not get
too caught up in what we've got now.
PS. And I'm sure you'll finish the work while I'm on honeymoon :)
How could I marry someone with more hair than me? http://baldalex.org
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/