Re: [PATCHSET 0/6 version 2] kmod: Optional timeout on the wait incall_usermodehelper_exec
From: Andrew Morton
Date: Tue Mar 27 2012 - 17:07:36 EST
On Mon, 26 Mar 2012 18:57:54 -0700
Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:
> My motivation is that I added yet another Kernel dependency on the
> call_usermodehelper() function and am not completely happy with the
> error case of having the user-mode program stuck forever. In such
> case I would like the Kernel part to timeout and properly error recover
> and clean up. So therefor the proposed 5th patch.
Before adding a new feature we should hear more about why you think
it's needed. afaik we haven't needed this capability in the past ten
years or so and may not need it for another ten. Hence we probably
shouldn't add it!
IOW, please explain at some length why you need this. Do you think
that there are existing call sites which can usefully use this feature?
Do you expect that new callers are likely to need this? etcetera.
Patches 1-3 are general cleanups and look good, so I grabbed those.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/