Re: [PATCH V2] iop-adma: Corrected array overflow in RAID6 Xscale(R) test.
From: Williams, Dan J
Date: Wed Mar 28 2012 - 04:30:39 EST
On Thu, Mar 15, 2012 at 11:07 AM, Don Morris <don.morris@xxxxxx> wrote:
> Bug: cppcheck reported overflow in array assignment (for loop walks
> 0 to IOP_ADMA_NUM_SRC_TEST+2, array size is IOP_ADMA_NUM_SRC_TEST).
> Reported as: https://bugzilla.kernel.org/show_bug.cgi?id=42677
> Test code pq_src array was grown by two elements to correspond with actual
> usage (IOP_ADMA_NUM_SRC_TEST+2), stack consumption was kept constant by
> modifying the pq_dest two element array which is only used when pq_src
> is referenced up to IOP_ADMA_NUM_SRC_TEST elements into the address
> of the new last two elements of the pq_src array. This is presumed to
> be the original intent but would be reliant on compilers always having
> pq_dest contiguous with the final element of pq_src.
> Note: This is a re-send of a request for review from two weeks ago.
> Looking for review (or shootdown), adding LKML to list for a wider
> audience. Thanks.
> Updated per review comments of Sergei Shtylyov <sshtylyov@xxxxxxxxxx>
> Signed-off-by: Don Morris <don.morris@xxxxxx>
Applied, thanks, and I'll send it along for Vinod's tree.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/