Re: [RFC PATCH 0/5] perf: Intel uncore pmu counting support

From: Ingo Molnar
Date: Wed Mar 28 2012 - 05:31:12 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> On Wed, Mar 28, 2012 at 08:49:28AM +0200, Ingo Molnar wrote:
> >
> > * Yan, Zheng <zheng.z.yan@xxxxxxxxx> wrote:
> >
> > > Hi, all
> > >
> > > Here is the RFC patches to add uncore counting support for Nehalem,
> > > Sandy Bridge and Sandy Bridge-EP, applied on top of current tip.
> > > The code is based on Lin Ming's old patches.
> > >
> > > You can use 'perf stat' to access to the uncore pmu. For example:
> > > perf stat -a -C 0 -e 'uncore_nhm/config=0xffff/' sleep 1
> >
> > My main complaint is that that's not user friendly *AT ALL*.
> >
> > You need to make this useful to mere mortals: go through the
> > SDM, categorize interesting looking events, look at how it can
>
> The main problem is that we don't know currently what events
> are really useful. People need to play around with the raw
> events first to find that out. But to do that really already
> need some in tree support because out of tree is too painful
> to use: it's a chicken and egg problem.

Nonsense. User-space hacks can be used for experimenting around,
raw access to /dev/msr has in fact be used to implement uncore
support in the past ... It has not helped the least to bring
useful tooling forward, I'd in fact argue the opposite: access
to raw events helped *hide* real usecases.

So guys, please give me some tangible reason to merge it and
some real way for developers to use it. The kernel is already
complex enough as-is, "it might be useful in the future" or
"I don't want to tell my sekrit usecases" does not fly.

If you can't be bothered to make it useful to everyone then
frankly we can't be bothered to maintain it upstream, it's
really that simple.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/